Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(idp): allow disabling full screen loader #1318

Merged
merged 2 commits into from
Sep 11, 2023
Merged

feat(idp): allow disabling full screen loader #1318

merged 2 commits into from
Sep 11, 2023

Conversation

adamdehaven
Copy link
Member

Summary

Adds new idpFullScreenLoader prop to disable the IdP full screen loader

Ready-To-Review Checklist

  • Tests: Includes any new/updated component tests
  • Docs: updates documentation as needed
  • Commit format/atomicity: the commits follow the guidelines outlined here

Ready-To-Merge Checklist

  • Reviewer - At least one reviewer has reviewed the following:
    • Functional: reviewed acceptance criteria and functionally tested the changes
    • Tests: Reviewer has checked the automated tests for correctness and completeness

@adamdehaven adamdehaven self-assigned this Sep 11, 2023
@adamdehaven adamdehaven requested a review from a team as a code owner September 11, 2023 13:11
@adamdehaven adamdehaven enabled auto-merge (squash) September 11, 2023 13:12
@adamdehaven adamdehaven merged commit 4196229 into main Sep 11, 2023
@adamdehaven adamdehaven deleted the feat/conditional-idp-loader branch September 11, 2023 14:37
kongponents-bot pushed a commit that referenced this pull request Sep 11, 2023
@semantic-release-bot
chore(release): 2.9.0 [skip ci]
eca62a6 
# [2.9.0](v2.8.10...v2.9.0) (2023-09-11)

### Features

* **idp:** allow disabling full screen loader ([#1318](#1318)) ([4196229](4196229))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 2.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValeryG ValeryG ValeryG approved these changes

Assignees

@adamdehaven adamdehaven

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamdehaven @kongponents-bot @ValeryG